Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tests/ and examples/demo/ #17003

Merged
merged 4 commits into from Jul 28, 2021
Merged

Remove tests/ and examples/demo/ #17003

merged 4 commits into from Jul 28, 2021

Conversation

brb
Copy link
Member

@brb brb commented Jul 27, 2021 •
edited

See commit msgs.

@brb
test: Move netpol-cyclones to tests/k8sT/manifests
17e33dd 
The tests/ directory is going to be removed.

Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb brb requested review from a team as code owners July 27, 2021 14:46
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 27, 2021
@brb brb requested a review from jrajahalme July 27, 2021 14:46
@brb brb added kind/cleanup This includes no functional changes. release-note/ci This PR makes changes to the CI. labels Jul 27, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jul 27, 2021
@brb
test: Move envoy smoke tests from tests/
703f182 
Jarno is still using them.

Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb brb changed the title Pr/brb/rm tests Remove tests/ and examples/demo/ Jul 27, 2021
brb added 2 commits July 27, 2021 16:51
@brb
test: Remove tests/ dir
1927dde 
The directory is no longer being used.

Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb
examples: Remove demo example
e1a28c0 
It's using libnetwork which we have stopped supporting.

Signed-off-by: Martynas Pumputis <m@lambda.lt>
qmonnet
qmonnet approved these changes Jul 27, 2021
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the changes in patch 3 (tests->test/envoy in Documentation, .gitignore, .dockerignore) would logically belong to patch 2 instead I think, but that's very minor and not blocking.

Looks good to me.

@brb
Copy link
Member Author

brb commented Jul 28, 2021

test-me-please

@brb
Copy link
Member Author

brb commented Jul 28, 2021

ci-aks failed to due potential connectivity issues:

Error: Unable to install Cilium: unable to execute "az ad sp create-for-rbac --scopes /subscriptions/986ec55c-1e77-4e2e-9ca5-dcbb34c7a110/resourceGroups/MC_cilium-cilium-1074187775_cilium-cilium-1074187775_westeurope --output json --only-show-errors": exit status 1
 ERROR: Please ensure you have network connection. Error detail: ('Connection aborted.', ConnectionResetError(104, 'Connection reset by peer'))

@brb
Copy link
Member Author

brb commented Jul 28, 2021

net-next hit:

@brb
Copy link
Member Author

brb commented Jul 28, 2021

test-1.16-netnext

This was referenced Jul 28, 2021
Closed
Closed
@vadorovsky vadorovsky merged commit b4c85c8 into master Jul 28, 2021
@vadorovsky vadorovsky deleted the pr/brb/rm-tests branch July 28, 2021 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanjsweet nathanjsweet nathanjsweet approved these changes

@qmonnet qmonnet qmonnet approved these changes

@vadorovsky vadorovsky vadorovsky approved these changes

@pchaigno pchaigno Awaiting requested review from pchaigno

@jrajahalme jrajahalme Awaiting requested review from jrajahalme

Assignees

@pchaigno pchaigno

@jrajahalme jrajahalme

Labels
kind/cleanup This includes no functional changes. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@brb @nathanjsweet @qmonnet @vadorovsky @pchaigno @jrajahalme