github: Misc improvements for the L4LB test suite

[brb]

See commit msgs.

Fix #16832
Fix #16870
Fix #17002

[gandro]

Note: This has a needs-backport/1.10 label, but the corresponding 1.10 workflow is actually now present in master:
https://github.com/cilium/cilium/blob/master/.github/workflows/tests-l4lb-v1.10.yaml

[brb]

This has a needs-backport/1.10 label, but the corresponding 1.10 workflow is actually now present in master:

@gandro Does this mean that for backports we will run the workflow from the main branch but not from a v1.10 backport branch?

[nbusseneau]

Does this mean that for backports we will run the workflow from the main branch but not from a v1.10 backport branch?

Kinda both: the workflows for issue_comment triggers must be present on the default branch (so yes, we can remove the backport label), however in the workflow itself the Set up job variables step is responsible for fetching the actual PR where the comment was posted. The SHA of this PR is then used for retrieving the right Cilium image to run in the workflow, so it does run in the context of the backport branch :)

 

LGTM, some comments below! I am not familiar with bash traps in the context of a GitHub workflow, did you try to manually fail the script while testing with the pull_request trigger, to see if it hit the trap as expected?

[brb]

I am not familiar with bash traps in the context of a GitHub workflow, did you try to manually fail the script while testing with the pull_request trigger, to see if it hit the trap as expected?

@nbusseneau The trap will run in the context of the VM instance, so all fine here.

[nbusseneau]

LGTM once we fix the following 👍🏻