Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: fix permissions #17008

Merged
merged 1 commit into from Aug 1, 2021

Conversation

nbusseneau
Copy link
Member

@nbusseneau nbusseneau commented Jul 28, 2021

contents permission is required to be able to access the repository with actions/checkout. It worked incidentally because the repo is public but let's make it cleaner.

pull-requests permission is required to allow retrieving information from the PR API. Likewise, it worked incidentally only because the repo is public.

`contents` permission is required to be able to access the repository
with actions/checkout. It worked incidentally because the repo is public
but let's make it cleaner.

`pull-requests` permission is required to allow retrieving information
from the PR API. Likewise, it worked incidentally only because the repo
is public.

Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
@nbusseneau nbusseneau added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels Jul 28, 2021
@nbusseneau nbusseneau requested review from a team as code owners July 28, 2021 13:16
@nbusseneau nbusseneau requested a review from pchaigno July 28, 2021 13:16
@nbusseneau nbusseneau requested a review from aanm July 28, 2021 13:16
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.10.4 Jul 29, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.9.10 Jul 29, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.8.12 Jul 29, 2021
@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 29, 2021
@nbusseneau
Copy link
Member Author

@aanm I don't think this PR needs to be backported considering it only affects CI 3.0 jobs, which are not present in any stable branch. Removing labels.

@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Needs backport from master in 1.10.4 Jul 29, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Needs backport from master in 1.9.10 Jul 29, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Needs backport from master in 1.8.12 Jul 29, 2021
@vadorovsky vadorovsky merged commit d800789 into cilium:master Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants