Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix missing quote in gcloud command for GKE #17014

Merged

Conversation

christarazi
Copy link
Member

This was causing the command to fail if copy-pasted directly.

Fixes: 3662560 ("Add new unified Helm guide")

Signed-off-by: Chris Tarazi chris@isovalent.com

This was causing the command to fail if copy-pasted directly.

Fixes: 3662560 ("Add new unified Helm guide")

Signed-off-by: Chris Tarazi <chris@isovalent.com>
@christarazi christarazi requested a review from a team as a code owner July 28, 2021 19:02
@christarazi christarazi added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. needs-backport/1.10 release-note/misc This PR makes changes that have no direct user impact. labels Jul 28, 2021
@christarazi christarazi requested a review from qmonnet July 28, 2021 19:02
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.10.4 Jul 28, 2021
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@qmonnet qmonnet added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 29, 2021
@nathanjsweet nathanjsweet merged commit 9fa20c8 into cilium:master Aug 2, 2021
This was referenced Aug 10, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.10 in 1.10.4 Aug 10, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.10 in 1.10.4 Aug 10, 2021
@christarazi christarazi deleted the pr/christarazi/fix-gke-cmd-docs branch August 10, 2021 16:48
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.10 to Backport done to v1.10 in 1.10.4 Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.10.4
Backport done to v1.10
Development

Successfully merging this pull request may close these issues.

None yet

5 participants