workflows: disable scheduled runs for 1.10 workflows #17023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the current setup, the scheduled runs on 1.10 workflows are testing exactly the same as the regular workflows. Since this doubles the amount and cost of testing for no reason, we disable schedule runs on 1.10 workflows. We can always re-enable them later on when we actually rework them to use the v1.10 branches instead. Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
nbusseneau
added
area/CI
joestringer
approved these changes
Jul 30, 2021
christarazi
approved these changes
Jul 30, 2021
At the moment, yes. |
nbusseneau
added
the
ready-to-merge
|
Marking as |
vadorovsky
approved these changes
Aug 1, 2021
nbusseneau
added a commit
to nbusseneau/cilium
that referenced
this pull request
Aug 4, 2021
We missed this one in cilium#17023. Fixes: e6287ba Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
krishgobinath
pushed a commit
to krishgobinath/cilium
that referenced
this pull request
Oct 20, 2021
We missed this one in cilium#17023. Fixes: e6287ba Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current setup, the scheduled runs on 1.10 workflows are testing exactly the same as the regular workflows. Since this doubles the amount and cost of testing for no reason, we disable schedule runs on 1.10 workflows.
We can always re-enable them later on when we actually rework them to use the v1.10 branches instead.