Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add clustermesh-apiserver description #17025

Merged
merged 1 commit into from Nov 8, 2021
Merged

docs: add clustermesh-apiserver description #17025

merged 1 commit into from Nov 8, 2021

Conversation

oblazek
Copy link
Contributor

@oblazek oblazek commented Jul 30, 2021 •
edited

Extend the clustermesh-apiserver README file with its description.

Fixes: #14096

Signed-off-by: Ondrej Blazek ondrej.blazek@firma.seznam.cz

@oblazek oblazek requested a review from a team as a code owner July 30, 2021 21:00
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 30, 2021
@aanm aanm requested a review from jrajahalme August 2, 2021 21:40
@aanm aanm added the release-note/misc This PR makes changes that have no direct user impact. label Aug 2, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 2, 2021
jrajahalme
jrajahalme requested changes Aug 5, 2021
View reviewed changes
Copy link
Member

@jrajahalme jrajahalme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some refinements requested :-)

clustermesh-apiserver/README.md Outdated Show resolved Hide resolved
clustermesh-apiserver/README.md Outdated Show resolved Hide resolved
clustermesh-apiserver/README.md Outdated Show resolved Hide resolved
clustermesh-apiserver/README.md Outdated Show resolved Hide resolved
jrajahalme
jrajahalme requested changes Sep 1, 2021
View reviewed changes
Copy link
Member

@jrajahalme jrajahalme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still some requested clarifications :-)

clustermesh-apiserver/README.md Outdated Show resolved Hide resolved
clustermesh-apiserver/README.md Outdated Show resolved Hide resolved
clustermesh-apiserver/README.md Outdated Show resolved Hide resolved
clustermesh-apiserver/README.md Show resolved Hide resolved
@maintainer-s-little-helper

This comment has been minimized.

Sign in to view
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Oct 11, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Oct 11, 2021
@aanm aanm requested a review from jrajahalme October 18, 2021 22:10
kkourt
kkourt approved these changes Oct 22, 2021
View reviewed changes
Copy link
Contributor

@kkourt kkourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor nits from me.
Thanks!

clustermesh-apiserver/README.md Outdated Show resolved Hide resolved
clustermesh-apiserver/README.md Outdated Show resolved Hide resolved
clustermesh-apiserver/README.md Outdated Show resolved Hide resolved
jrajahalme
jrajahalme approved these changes Oct 27, 2021
View reviewed changes
Copy link
Member

@jrajahalme jrajahalme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some detail is still missing, but this is much better than we had before.

@pchaigno pchaigno added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. labels Nov 5, 2021
@pchaigno
Copy link
Member

pchaigno commented Nov 5, 2021

@oblazek Could you please squash the two commits and rebase? 🙏

@oblazek
Copy link
Contributor Author

oblazek commented Nov 8, 2021

@oblazek Could you please squash the two commits and rebase? 🙏

sure, just a sec

@oblazek
docs: add clustermesh-apiserver description
a55f1b8 
Extend the clustermesh-apiserver README file with its description.

Fixes: cilium#14096

Signed-off-by: Ondrej Blazek <ondrej.blazek@firma.seznam.cz>
@pchaigno pchaigno added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. and removed dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. labels Nov 8, 2021
@pchaigno
Copy link
Member

pchaigno commented Nov 8, 2021

Thanks!

@pchaigno pchaigno merged commit f5609ee into cilium:master Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkourt kkourt kkourt approved these changes

@jrajahalme jrajahalme jrajahalme approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Describe clustermesh-apiserver architecture
5 participants
@oblazek @pchaigno @kkourt @jrajahalme @aanm