Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.github: Fix smoke tests sysdump collection from failing prematurely #17032

Merged
merged 1 commit into from Aug 4, 2021
Merged

.github: Fix smoke tests sysdump collection from failing prematurely #17032

merged 1 commit into from Aug 4, 2021

Conversation

christarazi
Copy link
Member

If the hubble observe command fails for whatever reason, we don't want
to prevent the collection of the sysdump.

Fixes: 0cbb855 (".github: Capture hubble flows when smoke test
fails")
Fixes: #16968

Signed-off-by: Chris Tarazi chris@isovalent.com

@christarazi
.github: Fix smoke tests sysdump collection from failing prematurely
6f44a7f 
If the `hubble observe` command fails for whatever reason, we don't want
to prevent the collection of the sysdump.

Fixes: 0cbb855 (".github: Capture hubble flows when smoke test
fails")
Fixes: cilium#16968

Signed-off-by: Chris Tarazi <chris@isovalent.com>
@christarazi christarazi added area/CI Continuous Integration testing issue or flake area/CI-improvement Topic or proposal to improve the Continuous Integration workflow release-note/ci This PR makes changes to the CI. kind/enhancement This would improve or streamline existing functionality. labels Aug 2, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Aug 2, 2021
@christarazi christarazi marked this pull request as ready for review August 2, 2021 21:53
@christarazi christarazi requested review from a team as code owners August 2, 2021 21:53
nbusseneau
nbusseneau approved these changes Aug 4, 2021
View reviewed changes
Copy link
Member

@nbusseneau nbusseneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. Didn't think a touch would be needed in this instance 🤔 Thanks!

@christarazi
Copy link
Member Author

@nbusseneau It is because of the tar invocation below which bundles up the hubble-flows.json file. If it doesn't exist because hubble observe failed, then tar will also fail.

@christarazi christarazi added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Aug 4, 2021
@joestringer joestringer merged commit a1b49bd into cilium:master Aug 4, 2021
@christarazi christarazi deleted the pr/christarazi/fix-artifacts-collection-smoke-tests branch August 4, 2021 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer approved these changes

@nbusseneau nbusseneau nbusseneau approved these changes

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake area/CI-improvement Topic or proposal to improve the Continuous Integration workflow kind/enhancement This would improve or streamline existing functionality. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@christarazi @joestringer @nbusseneau