node-neigh: Wait instead of sleeping in unit tests #17035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test-runtime |
|
Job 'Cilium-PR-Runtime-4.9' hit: #17034 (94.18% similarity) |
brb
requested changes
Aug 3, 2021
| @@ -1405,7 +1405,7 @@ func (s *linuxPrivilegedIPv4OnlyTestSuite) TestArpPingHandling(c *check.C) { | |||
| c.Assert(found, check.Equals, false) | |||
|
|
|||
| c.Assert(linuxNodeHandler.NodeAdd(nodev3), check.IsNil) | |||
| time.Sleep(100 * time.Millisecond) // insertNeighbor is invoked async | |||
| wait(nodev3.Identity(), nil, false) | |||
There was a problem hiding this comment.
Either you need to pass the now value or make the function wait to accept before = nil.
|
I'm wondering why all of sudden we started to hit the TestArp flakes again. Another issue: #17020. |
|
/mlh new-flake Cilium-PR-Runtime-4.9 👍 created #17038 |
aanm
force-pushed
the
pr/fix-privileged-unit-arp
branch
from
15b8060
to
c5d404a
Compare
brb
reviewed
Aug 3, 2021
| linuxNodeHandler.NodeCleanNeighbors() | ||
| wait(nodev3.Identity(), &now, true) |
aanm
force-pushed
the
pr/fix-privileged-unit-arp
branch
from
c5d404a
to
914c6a9
Compare
|
test-runtime |
|
Job 'Cilium-PR-Runtime-4.9' hit: #17034 (94.02% similarity) |
aanm
force-pushed
the
pr/fix-privileged-unit-arp
branch
from
914c6a9
to
2c9553b
Compare
|
test-runtime |
|
Job 'Cilium-PR-Runtime-4.9' hit: #17034 (94.23% similarity) |
We can inspect the neighLastPingByNextHop map to check when insertNeighbor() or deleteNeighbor() was called. Fixes: e68848b ("remove ARP entries left from previous Cilium run") Signed-off-by: André Martins <andre@cilium.io>
aanm
force-pushed
the
pr/fix-privileged-unit-arp
branch
from
2c9553b
to
f81fa2a
Compare
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.10
in 1.10.4
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.9
in 1.9.10
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.8
in 1.8.12
maintainer-s-little-helper
bot
moved this from Backport pending to v1.8
to Backport done to v1.8
in 1.8.12
maintainer-s-little-helper
bot
moved this from Backport pending to v1.8
to Backport done to v1.8
in 1.8.12
maintainer-s-little-helper
bot
moved this from Backport pending to v1.10
to Backport done to v1.10
in 1.10.4
This was referenced Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can inspect the neighLastPingByNextHop map to check
when insertNeighbor() or deleteNeighbor() was called.
Fixes: e68848b ("remove ARP entries left from previous Cilium run")
Signed-off-by: André Martins andre@cilium.io
Fixes #17034