New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Add HostPort conformance to upstream-k8s #17048
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joestringer
added
the
release-note/misc
This PR makes changes that have no direct user impact.
label
Aug 4, 2021
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
label
Aug 4, 2021
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
label
Aug 4, 2021
test-upstream-k8s |
christarazi
approved these changes
Aug 4, 2021
Seems to be successfully failing 😁 https://jenkins.cilium.io/job/Cilium-PR-K8s-Upstream/3268/execution/node/73/log/
|
Portmap chaining is how hostport is supported when kubeProxyReplacement is disabled or not available. Enable this by default to unblock the conformance tests. Signed-off-by: Joe Stringer <joe@cilium.io>
Now that we enable portmap chaining by default in the upstream-k8s conformance testing script, we can enable the hostport tests. In future we can also support this test with kube-proxy-replacement but that requires solving a couple of additional bugs first, see issue 14287. Signed-off-by: Joe Stringer <joe@cilium.io>
joestringer
force-pushed
the
submit/hostport-conformance
branch
from
August 4, 2021 01:37
746e690
to
fa81a5e
Compare
test-upstream-k8s |
christarazi
approved these changes
Aug 4, 2021
christarazi
added
area/CI
Continuous Integration testing issue or flake
area/CI-improvement
Topic or proposal to improve the Continuous Integration workflow
kind/enhancement
This would improve or streamline existing functionality.
sig/k8s
Impacts the kubernetes API, or kubernetes -> cilium internals translation layers.
labels
Aug 4, 2021
joestringer
added
the
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
label
Aug 4, 2021
This only modifies a script used in the |
hswong3i
added a commit
to alvistack/ansible-role-kube_cilium
that referenced
this pull request
Aug 13, 2022
helm template cilium cilium/cilium \ --version 1.12.0 \ --namespace kube-system \ --set bpf.preallocateMaps=false \ --set cluster.id=0 \ --set cluster.name=4e8b0505-4c52-57ab-a7f4-481e7ed3a2e3 \ --set cni.binPath=/usr/libexec/cni \ --set cni.chainingMode=portmap \ --set cni.exclusive=true \ --set enableIPv4Masquerade=true \ --set enableIPv6Masquerade=false \ --set externalIPs.enabled=true \ --set hostPort.enabled=true \ --set hostServices.enabled=true \ --set hubble.enabled=false \ --set ipam.mode=cluster-pool \ --set ipam.operator.clusterPoolIPv4MaskSize=24 \ --set ipam.operator.clusterPoolIPv4PodCIDRList=10.233.64.0/18 \ --set ipv4.enabled=true \ --set ipv6.enabled=false \ --set kubeProxyReplacement=partial \ --set nodePort.enabled=true \ --set nodeinit.enabled=true \ --set nodeinit.securityContext.privileged=true \ --set operator.replicas=1 \ --set operator.securityContext.privileged=true \ --set securityContext.privileged=true \ --set sessionAffinity=true \ --set tunnel=vxlan \ | yq . > templates/etc/kubernetes/addons/60-cilium.yml.j2 See cncf/k8s-conformance#2093 Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/CI
Continuous Integration testing issue or flake
area/CI-improvement
Topic or proposal to improve the Continuous Integration workflow
kind/enhancement
This would improve or streamline existing functionality.
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/misc
This PR makes changes that have no direct user impact.
sig/k8s
Impacts the kubernetes API, or kubernetes -> cilium internals translation layers.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add HostPort Conformance test to the upstream-k8s testing so that we get
coverage for this test in CI.
Related: #14287