Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netns: Fix socket leak #17051

Merged
merged 2 commits into from Aug 19, 2021
Merged

netns: Fix socket leak #17051

merged 2 commits into from Aug 19, 2021

Conversation

brb
Copy link
Member

@brb brb commented Aug 4, 2021

Close the socket if it has been successfully created.

Fixes: 0a4a393 ("bpf: Derive host netns cookie via SO_NETNS_COOKIE")
Reported-by: Daniel Borkmann daniel@iogearbox.net

@brb brb added release-note/bug This PR fixes an issue in a previous release of Cilium. sig/loadbalancing labels Aug 4, 2021
@brb brb requested a review from borkmann August 4, 2021 16:22
@brb brb requested a review from a team as a code owner August 4, 2021 16:22
pkg/netns/cookie.go Show resolved Hide resolved
@aanm aanm added release-note/misc This PR makes changes that have no direct user impact. and removed release-note/bug This PR fixes an issue in a previous release of Cilium. labels Aug 5, 2021
@brb brb requested a review from aanm August 5, 2021 06:33
@aanm
Copy link
Member

aanm commented Aug 5, 2021

test-me-please

@brb brb force-pushed the pr/brb/fix-socket-netns-leak branch from 64a1aa6 to 50c8b85 Compare August 13, 2021 10:15
@brb
Copy link
Member Author

brb commented Aug 13, 2021

test-me-please

Close the socket if it has been successfully created.

Fixes: 0a4a393 ("bpf: Derive host netns cookie via SO_NETNS_COOKIE")
Reported-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: Martynas Pumputis <m@lambda.lt>
Fixes: 0a4a393 ("bpf: Derive host netns cookie via SO_NETNS_COOKIE")
Reported-by: André Martins <andre@cilium.io>
Signed-off-by: Martynas Pumputis <m@lambda.lt>
@tklauser
Copy link
Member

ConformanceEKS failed on #17139 which was fixed on master in #17140, merging.

@tklauser tklauser merged commit a705482 into master Aug 19, 2021
@tklauser tklauser deleted the pr/brb/fix-socket-netns-leak branch August 19, 2021 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants