New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
netns: Fix socket leak #17051
Merged
Merged
netns: Fix socket leak #17051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brb
added
release-note/bug
This PR fixes an issue in a previous release of Cilium.
sig/loadbalancing
labels
Aug 4, 2021
borkmann
approved these changes
Aug 4, 2021
gandro
approved these changes
Aug 4, 2021
aanm
requested changes
Aug 4, 2021
aanm
added
release-note/misc
This PR makes changes that have no direct user impact.
and removed
release-note/bug
This PR fixes an issue in a previous release of Cilium.
labels
Aug 5, 2021
aanm
approved these changes
Aug 5, 2021
test-me-please |
brb
force-pushed
the
pr/brb/fix-socket-netns-leak
branch
from
August 13, 2021 10:15
64a1aa6
to
50c8b85
Compare
test-me-please |
Close the socket if it has been successfully created. Fixes: 0a4a393 ("bpf: Derive host netns cookie via SO_NETNS_COOKIE") Reported-by: Daniel Borkmann <daniel@iogearbox.net> Signed-off-by: Martynas Pumputis <m@lambda.lt>
Fixes: 0a4a393 ("bpf: Derive host netns cookie via SO_NETNS_COOKIE") Reported-by: André Martins <andre@cilium.io> Signed-off-by: Martynas Pumputis <m@lambda.lt>
tklauser
approved these changes
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close the socket if it has been successfully created.
Fixes: 0a4a393 ("bpf: Derive host netns cookie via SO_NETNS_COOKIE")
Reported-by: Daniel Borkmann daniel@iogearbox.net