tooling: introduce target for generating json compilation database #17065
Conversation
both mainstream c language servers (clangd, ccls) require a json compilation database to function correctly. this patch adds a makefile target which utilizes the 'bear' cli to compile this json database. after the database is generated all code within the bpf directory is indexable by clangd and ccls allowing the tooling to work correctly. Signed-off-by: Louis DeLosSantos <louis@isovalent.com>
ldelossa
added
the
release-note/misc
|
|
||
|
|
||
| BEAR_CLI = $(shell which bear 2> /dev/null) | ||
| gen_compile_commands: |
There was a problem hiding this comment.
Any reason not to use the actual target (compile_commands.json) here with the correct dependencies (presumably all C code in the directory)?
|
@twpayne i was keeping the naming consistent with the way you do this in the kernel: https://github.com/torvalds/linux/tree/master/scripts/clang-tools Cant speak for other tools, but the c LSPs tie themselves to the code base tightly, so its typical, and almost mandatory that the build systems are aware of their existence. Tho, only via this json compilation database. |
christarazi
added
area/build
If it's an optional dependency available to developers who need it, it seems fine to me. I don't think we're taking on a big maintenance burden from adding stuff like this. For a similar example, I added |
ldelossa
added
the
ready-to-merge
|
Changes only effect bpf Makefile, integration tests can be skipped. |
both mainstream c language servers (clangd, ccls) require a json compilation
database to function correctly.
this patch adds a makefile target which utilizes the 'bear' cli to
compile this json database.
after the database is generated all code within the bpf directory is
indexable by clangd and ccls allowing the tooling to work correctly.
Signed-off-by: Louis DeLosSantos louis@isovalent.com