workflows: retry GCP VM creation up to 3 times #17068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbusseneau
added
area/CI
Fixes an issue where the GCP VM fails to create: ``` Run gcloud compute instances create cilium-cilium-cli-1046557892-vm \ WARNING: You have selected a disk size of under [200GB]. This may result in poor I/O performance. For more information, see: https://developers.google.com/compute/docs/disks#performance. ERROR: (gcloud.compute.instances.create) Could not fetch resource: - The resource 'projects/***/regions/us-west2/subnetworks/default' is not ready ``` From GCP documentation, this comes from simultaneous resource operations (https://cloud.google.com/compute/docs/troubleshooting/troubleshooting-vm-creation) however we have no control over that. Their only recommendation is to add retries. Considering it's an infrastructure issue and it also is easily contained to the GCP VM creation step, this is acceptable. Picked up from cilium/cilium-cli#463. Fixes: #17063 Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
|
Link to test run of workflow changes: https://github.com/cilium/cilium/actions/runs/1105157552
|
|
Removing temporary test commit. |
nbusseneau
force-pushed
the
pr/workflows-external-workloads-vm-retry
branch
from
70acc51
to
c0414ea
Compare
aanm
approved these changes
Aug 6, 2021
christarazi
approved these changes
Aug 6, 2021
nbusseneau
added
the
ready-to-merge
|
Marking as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the GCP VM fails to create:
From GCP documentation, this comes from simultaneous resource operations (https://cloud.google.com/compute/docs/troubleshooting/troubleshooting-vm-creation) however we have no control over that. Their only recommendation is to add retries.
Considering it's an infrastructure issue and it also is easily contained to the GCP VM creation step, this is acceptable.
Picked up from cilium/cilium-cli#463.
Fixes: #17063