datapath: Sort VLAN IDs in generated macros #17105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrajahalme
added
kind/bug
|
test-me-please Job 'Cilium-PR-K8s-1.20-kernel-4.19' failed and has not been observed before, so may be related to your PR: Click to show.Test NameFailure OutputIf it is a flake, comment Job 'Cilium-PR-K8s-1.16-net-next' hit: #17060 (85.43% similarity) |
|
None of the flakes are related to this PR that fixes another flake. |
aditighag
reviewed
Aug 10, 2021
Good catch, accidentally based this on another branch rather than master, will rebase! |
Apparently netlink.LinkList() can return VLAN IDs in any order. Sort them to get consistent generated macros. Fixes: cilium#17104 Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
jrajahalme
force-pushed
the
linux-datapath-sort-vlanids
branch
from
de59746
to
e455110
Compare
|
@aditighag Rebased :-) |
|
test-me-please |
nebril
approved these changes
Aug 10, 2021
twpayne
approved these changes
Aug 10, 2021
jrajahalme
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently netlink.LinkList() can return VLAN IDs in any order. Sort
them to get consistent generated macros.
Fixes: #17104
Signed-off-by: Jarno Rajahalme jarno@isovalent.com