Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go to 1.16.7 #17116

Merged
merged 2 commits into from Aug 19, 2021
Merged

Update Go to 1.16.7 #17116

merged 2 commits into from Aug 19, 2021

Conversation

tklauser
Copy link
Member

@tklauser tklauser commented Aug 10, 2021

First commit remove an unnecessary step from the update-golang-image.sh script, second commit updates Go to 1.16.7 and updates to new Cilium images built with that version.

Supersedes #16866

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 10, 2021
@tklauser tklauser temporarily deployed to release-base-images August 10, 2021 08:45 Inactive
@tklauser tklauser temporarily deployed to release-base-images August 10, 2021 08:45 Inactive
@tklauser tklauser added the release-note/misc This PR makes changes that have no direct user impact. label Aug 10, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 10, 2021
@tklauser tklauser temporarily deployed to release-base-images August 10, 2021 08:55 Inactive
@tklauser tklauser temporarily deployed to release-base-images August 10, 2021 08:55 Inactive
@tklauser tklauser temporarily deployed to release-base-images August 10, 2021 09:17 Inactive
@tklauser tklauser temporarily deployed to release-base-images August 10, 2021 09:17 Inactive
@tklauser tklauser marked this pull request as ready for review August 10, 2021 09:18
@tklauser tklauser requested review from a team as code owners August 10, 2021 09:18
@tklauser tklauser requested a review from pchaigno August 10, 2021 09:18
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch with the alpine variant!

@tklauser
Copy link
Member Author

tklauser commented Aug 10, 2021

test-me-please

Job 'Cilium-PR-K8s-1.16-net-next' failed and has not been observed before, so may be related to your PR:

Click to show.

Test Name

K8sServicesTest Checks service across nodes Tests NodePort BPF Tests with direct routing Test NodePort with netfilterCompatMode=true

Failure Output

FAIL: Can not connect to service "http://192.168.36.11:31887" from outside cluster (1/10)

If it is a flake, comment /mlh new-flake Cilium-PR-K8s-1.16-net-next so I can create a new GitHub issue to track it.

@tklauser tklauser temporarily deployed to release-base-images August 11, 2021 09:56 Inactive
@tklauser tklauser temporarily deployed to release-base-images August 11, 2021 09:56 Inactive
@tklauser tklauser temporarily deployed to release-base-images August 11, 2021 11:23 Inactive
@tklauser tklauser temporarily deployed to release-base-images August 11, 2021 11:23 Inactive
@tklauser tklauser temporarily deployed to release-base-images August 11, 2021 11:34 Inactive
@tklauser tklauser temporarily deployed to release-base-images August 11, 2021 11:34 Inactive
@tklauser
Copy link
Member Author

tklauser commented Aug 11, 2021

test-me-please

Job 'Cilium-PR-K8s-1.21-kernel-4.9' failed and has not been observed before, so may be related to your PR:

Click to show.

Test Name

K8sDatapathConfig MonitorAggregation Checks that monitor aggregation restricts notifications

Failure Output

FAIL: Found 1 io.cilium/app=operator logs matching list of errors that must be investigated:

If it is a flake, comment /mlh new-flake Cilium-PR-K8s-1.21-kernel-4.9 so I can create a new GitHub issue to track it.

Job 'Cilium-PR-K8s-1.16-net-next' has 1 failure but they might be new flake since it also hit 1 known flake: #17060 (86.07)

The golang-alpine image is no longer used since commit 2960b4e
("images: Move hubble-proto into cilium-builder"). Remove the
corresponding update step from update-golang-image.sh.

Signed-off-by: Tobias Klauser <tobias@cilium.io>
Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser temporarily deployed to release-base-images August 13, 2021 15:38 Inactive
@tklauser tklauser temporarily deployed to release-base-images August 13, 2021 15:38 Inactive
@tklauser
Copy link
Member Author

test-me-please

@tklauser
Copy link
Member Author

tklauser commented Aug 16, 2021

test-gke

previous run timed out waiting for images to be built: https://jenkins.cilium.io/job/Cilium-PR-K8s-GKE/6213/

@tklauser
Copy link
Member Author

tklauser commented Aug 18, 2021

/mlh new-flake Cilium-PR-K8s-1.21-kernel-4.9

👍 created #17184 #17185

@tklauser
Copy link
Member Author

test-1.21-4.9

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Aug 18, 2021
@tklauser tklauser merged commit 7968e9a into master Aug 19, 2021
@tklauser tklauser deleted the pr/tklauser/go-1.16.7 branch August 19, 2021 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants