Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workflows: Fix Hubble flow capture in smoke tests #17137

Merged
merged 1 commit into from Aug 13, 2021
Merged

workflows: Fix Hubble flow capture in smoke tests #17137

merged 1 commit into from Aug 13, 2021

Conversation

pchaigno
Copy link
Member

The step "Capture cilium-sysdump" currently fails in smoke tests with:

gzip: stdin: not in gzip format
tar: Child returned status 1
tar: Error is not recoverable: exiting now
Error: Process completed with exit code 2.

This is happening because we attempt to download the latest hubble binary at URL https://github.com/cilium/hubble/releases/download/latest/hubble-linux-amd64.tar.gz and fail to decompress the downloaded file. That's because the downloaded file contains only "Not found".

Indeed, URL https://github.com/cilium/hubble/releases/download/latest/hubble-linux-amd64.tar.gz doesn't exist, the correct URL is https://github.com/cilium/hubble/releases/latest/download/hubble-linux-amd64.tar.gz. Never mind that other releases are downloaded at https://github.com/cilium/hubble/releases/download/$TAG/hubble-linux-amd64.tar.gz ¯_(ツ)_/¯

Fixes: #16968
/cc @christarazi

@pchaigno pchaigno added kind/bug/CI This is a bug in the testing code. area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels Aug 11, 2021
@pchaigno pchaigno requested review from a team as code owners August 11, 2021 15:34
tklauser
tklauser reviewed Aug 11, 2021
View reviewed changes
Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another option would be to use the latest stable Hubble version per stable.txt as documented in https://docs.cilium.io/en/v1.10/gettingstarted/hubble_setup/#install-the-hubble-client

@pchaigno
Copy link
Member Author

Another option would be to use the latest stable Hubble version per stable.txt as documented in https://docs.cilium.io/en/v1.10/gettingstarted/hubble_setup/#install-the-hubble-client

Yep, I considered that, but as far as I can see, latest from GitHub will always point to the latest release in Hubble's case. (It would be different with Cilium where we sometimes release patch versions for other minor releases than the last.)

@pchaigno pchaigno marked this pull request as draft August 11, 2021 17:19
@christarazi
Copy link
Member

😬 Ouch I must have done a copy-pasta and forgot to update the IPv4 smoke test workflow file, apologies.

@pchaigno pchaigno force-pushed the smoke-tests-fix-sysdump-capture branch from e652e46 to 6d7383a Compare August 11, 2021 19:14
@pchaigno pchaigno marked this pull request as ready for review August 11, 2021 19:26
nbusseneau
nbusseneau approved these changes Aug 12, 2021
View reviewed changes
Copy link
Member

@nbusseneau nbusseneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess we're not moving to stable.txt yet 🚀

@pchaigno
Copy link
Member Author

Guess we're not moving to stable.txt yet rocket

Oh wait! What did I do 🤦

@pchaigno
workflows: Fix Hubble flow capture in smoke tests
a074a0a 
The step "Capture cilium-sysdump" currently fails in smoke tests with:

    gzip: stdin: not in gzip format
    tar: Child returned status 1
    tar: Error is not recoverable: exiting now
    Error: Process completed with exit code 2.

This is happening because we attempt to download the latest hubble
binary at URL github.com/cilium/hubble/releases/download/latest and fail
to decompress the downloaded file. That's because the downloaded file
contains only "Not found".

Indeed, URL cilium/hubble/releases/download/latest doesn't exist, the
correct URL is cilium/hubble/releases/latest/download. Nevermind that
other releases are downloaded at
github.com/cilium/hubble/releases/download/$TAG ¯\_(ツ)_/¯

Fixes: 0cbb855 (".github: Capture hubble flows when smoke test fails")
Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno pchaigno force-pushed the smoke-tests-fix-sysdump-capture branch from 6d7383a to a074a0a Compare August 12, 2021 11:03
@pchaigno
Copy link
Member Author

It should be okay now :-)
The first PR after PTO is always difficult 😩

@nbusseneau
Copy link
Member

nbusseneau commented Aug 12, 2021 •
edited

PTO = Pain To Overcome? :trollface:

@pchaigno
Copy link
Member Author

Smoke tests are passing and reviews are in. Marking ready to merge.

@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Aug 12, 2021
@ti-mo ti-mo merged commit 822bfa5 into cilium:master Aug 13, 2021
@pchaigno pchaigno deleted the smoke-tests-fix-sysdump-capture branch August 13, 2021 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tklauser tklauser tklauser approved these changes

@christarazi christarazi christarazi approved these changes

@nbusseneau nbusseneau nbusseneau approved these changes

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake kind/bug/CI This is a bug in the testing code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pchaigno @christarazi @nbusseneau @tklauser @ti-mo