Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpf: Cleanup datapath macros #17150

Merged
merged 2 commits into from Aug 17, 2021
Merged

bpf: Cleanup datapath macros #17150

merged 2 commits into from Aug 17, 2021

Conversation

pchaigno
Copy link
Member

See commits for details.

@pchaigno pchaigno added sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. labels Aug 12, 2021
@pchaigno pchaigno marked this pull request as ready for review August 13, 2021 07:54
@pchaigno pchaigno requested review from a team August 13, 2021 07:54
@pchaigno pchaigno requested review from a team as code owners August 13, 2021 07:54
@pchaigno pchaigno requested a review from borkmann August 13, 2021 07:54
@pchaigno
bpf: Remove references to unused macros
f8deca7 
Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno
bpf: Remove macros for service types
cdfe3c9 
This commit removes ENABLE_LOADBALANCER, ENABLE_EXTERNAL_IP, and
ENABLE_HOSTPORT. The agent-level options are kept and, if disabled,
services of the corresponding types won't be populated in BPF maps.

The goal of this commit is to reduce the number of datapath options we
need to cover in complexity tests. Removing 3 options can lead to as
much as an x8 reduction. Since we won't populate the BPF maps if those
options are disabled, we don't really need the macros.

Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno
Copy link
Member Author

test-me-please

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Aug 17, 2021
@ti-mo ti-mo merged commit 040d264 into cilium:master Aug 17, 2021
@pchaigno pchaigno deleted the cleanup-datapath-macros branch August 17, 2021 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borkmann borkmann borkmann approved these changes

@vadorovsky vadorovsky vadorovsky approved these changes

Assignees
No one assigned
Labels
kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pchaigno @borkmann @vadorovsky @ti-mo