treewide: convert more license headers to SPDX

[twpayne]

Running tools/spdxconv caught a few files not using SPDX, mostly because they were new files created just before the SPDX change.

Refs #16887.

Signed-off-by: Tom Payne tom@isovalent.com

[ti-mo]

Consider me out of the loop, but how do generated files get their SPDX (or license) headers?

[glibsm]

Upon running make in the api/v1 the license is restored back to fully apache2

> git status
On branch pr/twpayne/more-spdx
nothing to commit, working tree clean

> cd api/v1; make
[...]
make: Leaving directory '/src'

> git status
On branch pr/twpayne/more-spdx
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   flow/flow.pb.go
        modified:   observer/observer.pb.go
        modified:   peer/peer.pb.go
        modified:   recorder/recorder.pb.go
        modified:   relay/relay.pb.go

no changes added to commit (use "git add" and/or "git commit -a")

> git diff flow/flow.pb.go
diff --git a/api/v1/flow/flow.pb.go b/api/v1/flow/flow.pb.go
index 917597c413..5f5aabcc70 100644
--- a/api/v1/flow/flow.pb.go
+++ b/api/v1/flow/flow.pb.go
@@ -1,5 +1,16 @@
-// SPDX-License-Identifier: Apache-2.0
 // Copyright 2019 Authors of Hubble
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.

[glibsm]

As far as I can tell the license is copied from the .proto file when the code is generated.

❯ head -3 observer/observer.proto
// This is my custom license setup.
// Copyright 2019 Authors of Hubble


❯ head -3 observer/observer.pb.go
// SPDX-License-Identifier: Apache-2.0
// Copyright 2019 Authors of Hubble

❯ make
[...]
make: Leaving directory '/src'

❯ head -3 observer/observer.pb.go
// This is my custom license setup.
// Copyright 2019 Authors of Hubble

[ldelossa]

the original commit that introduced the spdxconv tool only updated this file:

https://github.com/cilium/cilium/blob/master/hack/custom-boilerplate.go.txt

@glibsm I thought that was going to take care of any protobuf gens and make generated files use the correct license header.

Needs more work to account for generated files

[twpayne]

OK, .proto files updated, and I've verified that make generate-hubble-api propagates the SPDX licence header from the .proto file to the generated .pb.go.

[twpayne]

Note that this is a documentation-only change.

The CI failure in the ConformanceKind1.19 / installation-and-connectivity check looks similar to #16392.