workflows: Fix change detection of comment-triggered jobs #17171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 98e6ea4 ("workflows: Improve the change check for issue_comment triggers") modified the change detection logic of comment-triggered jobs to use a more appropriate base commit. It used the 'github.event.pull_request.commits_url' context to retrieve the list of commits. However, this context is not available to comment-triggered jobs and the jobs are therefore failing. Instead, we need to retrieve the commits_url from the pull request API object, which we are already downloading. Fixes: 98e6ea4 ("workflows: Improve the change check for issue_comment triggers") Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
added
kind/bug/CI
Commit 98e6ea4 ("workflows: Improve the change check for issue_comment triggers") and its subsequent fix (see previous commit) missed the L4LB workflow. This commit fixes it by applying the same modifications to the L4LB workflow. Fix: 98e6ea4 ("workflows: Improve the change check for issue_comment triggers") Signed-off-by: Paul Chaignon <paul@cilium.io>
nbusseneau
approved these changes
Aug 16, 2021
tklauser
approved these changes
Aug 16, 2021
pchaigno
added
the
ready-to-merge
|
I tested the Bash changes manually and reviews are in. I've marked as ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 98e6ea4 ("workflows: Improve the change check for issue_comment triggers") modified the change detection logic of comment-triggered jobs to use a more appropriate base commit. It used the
github.event.pull_request.commits_urlcontext to retrieve the list of commits. However, this context is not available to comment-triggered jobs and the jobs are therefore failing.Instead, we need to retrieve the
commits_urlfrom the pull request API object, which we are already downloading.Fixes: #16841.