workflows: Revert changes to comment-triggered workflows #17173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit reverts 98e6ea4 ("workflows: Improve the change check for issue_comment triggers"). That issue and its tentative fix are breaking comment-triggered workflows. In the latest version, it was failing because 'git rev-parse' needs the pull request's branch to be fetched to work. Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
added
kind/bug/CI
aanm
approved these changes
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit reverts 98e6ea4 ("workflows: Improve the change check for issue_comment triggers").
That issue and its tentative fix are breaking comment-triggered workflows. In the latest version, it was failing because
git rev-parseneeds the pull request's branch to be fetched to work.