daemon: New route-based device detection and reconfiguration #17187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
joamaki
commented
Aug 18, 2021
joamaki
force-pushed
the
pr/joamaki/new-device-detection-and-reconfiguration
branch
from
062c88b
to
f720cd9
Compare
|
test-me-please |
joamaki
force-pushed
the
pr/joamaki/new-device-detection-and-reconfiguration
branch
2 times, most recently
from
bf28d87
to
c9a70f9
Compare
|
test-me-please |
joamaki
force-pushed
the
pr/joamaki/new-device-detection-and-reconfiguration
branch
3 times, most recently
from
a1c65db
to
3649a21
Compare
|
ci-gke |
|
test-runtime |
This helper is useful in other places as well. Renamed it to DeduplicateStrings as KeepUniqueNames is confusing as the name implies that only unique names would be left, e.g. [a,b,b] => [a]. Signed-off-by: Jussi Maki <jussi@isovalent.com>
This implements a new device detection for kube-proxy-replacement and bandwidth manager. Devices are discovered by looking at all global unicast routes configured in the system and extracting from them suitable devices for Cilium to attach to. Additionally this PR adds a runtime datapath reconfiguration for new devices discovered at runtime. When a new device is detected the node addressing information is rebuilt, node_config.h regenerated, the datapath reloaded and finally the load-balancing service map is rebuilt to include the IP addresses of the new device. Signed-off-by: Jussi Maki <jussi@isovalent.com>
joamaki
force-pushed
the
pr/joamaki/new-device-detection-and-reconfiguration
branch
from
3649a21
to
811e538
Compare
|
Commit 811e538 does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
maintainer-s-little-helper
bot
added
the
dont-merge/needs-sign-off
|
I've split the initial device detection stuff into #17219. Keeping this open for reference for now. |
joamaki
deleted the
pr/joamaki/new-device-detection-and-reconfiguration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a new device detection for kube-proxy-replacement
and bandwidth manager. Devices are discovered by looking at all
global unicast routes configured in the system and extracting
from them suitable devices for Cilium to attach to.
Additionally this PR adds a runtime datapath reconfiguration for
new devices discovered at runtime. When a new device is detected
the node addressing information is rebuilt, node_config.h regenerated,
the datapath reloaded and finally the load-balancing service map is
rebuilt to include the IP addresses of the new device.
TODO: