New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Go to 1.17 #17190
Update Go to 1.17 #17190
Conversation
190daaf
to
24307fe
Compare
Signed-off-by: Tobias Klauser <tobias@cilium.io>
Bump the go version in go.mod to 1.17. This will change the module graph to include only the immediate dependencies of other go 1.17 modules, not their full transitive dependencies. As a consequence of this, the newly-added requirements on indirect dependencies are added by `go mod tidy` in a separate require block. See https://golang.org/doc/go1.17#graph-pruning and https://golang.org/ref/mod#graph-pruning for details. Signed-off-by: Tobias Klauser <tobias@cilium.io>
24307fe
to
5396672
Compare
Starting with Go 1.17, `//go:build` lines are preferred over `// +build` lines, see https://golang.org/doc/go1.17#build-lines and https://golang.org/design/draft-gobuild for details. This change was generated by running Go 1.17 `gofmt -w .` which automatically adds `//go:build` lines based on the existing `// +build` lines. Signed-off-by: Tobias Klauser <tobias@cilium.io>
test-me-please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How many teams do you want to request review?
Yes
😄
Received 4 reviews from teams covering the most important aspects of the change (@cilium/build, @cilium/ci-structure and @cilium/vendor). The other groups were requested due to the |
First commit updates the Go version for Cilium build and updates the Docker images.
Second commit changes
go.mod
togo 1.17
to use the new module graph pruning, see https://golang.org/doc/go1.17#graph-pruningThird commit adds
//go:build
lines in addition to existing//+build
lines, as automatically done bygofmt
in Go 1.17. Note that also some files generated bydeepcopy-gen
were changed. These changes will be lost on the next update until we update to a version ofdeepcopy-gen
which includes kubernetes-sigs/controller-tools#595.