Rename hostFirewall and mark stable
#17221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchaigno
added
area/documentation
pchaigno
force-pushed
the
prepare-for-stable-hsotfw
branch
from
8848312
to
414094b
Compare
To plan for future additions to the set of host firewall options, it's better to have hostFirewall be a map rather than a boolean. We should do this now before the host firewall is stable, even if we don't yet have a use case for it. Signed-off-by: Paul Chaignon <paul@cilium.io>
The remaining issues with the host firewall and kube-proxy are resolved. The race condition on node labels was also addressed and the host firewall's status is now present in cilium status. We can now mark the host firewall stable regardless of KPR status. Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
force-pushed
the
prepare-for-stable-hsotfw
branch
from
414094b
to
d9ddba4
Compare
|
test-me-please |
pchaigno
requested review from
a team,
nathanjsweet,
tklauser,
qmonnet and
errordeveloper
maintainer-s-little-helper
bot
assigned nathanjsweet and tklauser and unassigned nathanjsweet
pchaigno
removed
the
dont-merge/blocked
tklauser
approved these changes
Aug 30, 2021
errordeveloper
approved these changes
Sep 1, 2021
|
The changes covered by @cilium/policy are minor (related to the Helm value change in the docs & tests), so I think it's okay to not wait for those reviews. All tests are passing so marking this ready to merge. |
pchaigno
added
the
ready-to-merge
maintainer-s-little-helper
bot
removed
the
ready-to-merge
pchaigno
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits for details.