New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/fqdn: use LRU in FQDN policy calculation #17224
Conversation
test-me-please Job 'Cilium-PR-K8s-1.19-kernel-5.4' failed and has not been observed before, so may be related to your PR: Click to show.Test Name
Failure Output
If it is a flake, comment Job 'Cilium-PR-K8s-GKE' failed and has not been observed before, so may be related to your PR: Click to show.Test Name
Failure Output
If it is a flake, comment Job 'Cilium-PR-K8s-1.16-net-next' has 1 failure but they might be new flake since it also hit 1 known flake: #17176 (91.52) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor docs rewording suggested
test-1.16-netnext |
test-1.19-5.4 |
test-gke |
ci-eks |
Using an LRU for the memory-intensive operations such as regex.Compile bring some benefits as presented in the following benchmarks [1]. These benchmarks assumed there were 2 CNPs that shared 100 FQDN `matchPattern` on a node with 20 endpoints. [1] ``` name old time/op new time/op delta _perEPAllow_setPortRulesForID-8 13.9ms ± 6% 1.2ms ±63% -91.10% (p=0.008 n=5+5) name old alloc/op new alloc/op delta _perEPAllow_setPortRulesForID-8 17.4MB ± 0% 0.6MB ± 0% -96.56% (p=0.008 n=5+5) name old allocs/op new allocs/op delta _perEPAllow_setPortRulesForID-8 42.8k ± 0% 8.1k ± 0% -81.13% (p=0.008 n=5+5) ``` Signed-off-by: André Martins <andre@cilium.io>
d223f16
to
a6e0c8c
Compare
test-me-please Job 'Cilium-PR-K8s-GKE' failed and has not been observed before, so may be related to your PR: Click to show.Test Name
Failure Output
If it is a flake, comment |
The test was passing before I made the comment change. It also doesn't load any FQDN policies, so probably unrelated to this pull request. /mlh new-flake Cilium-PR-K8s-GKE 👍 created #17270 |
The GKE flake is unrelated (see above) and AKS has been failing for a while. All tests were passing before I changed the comment and rebased. All team review requests are covered. Marking ready to merge. |
Using an LRU for the memory-intensive operations such as regex.Compile
bring some benefits as presented in the following benchmarks [1]. These
benchmarks assumed there were 2 CNPs that shared 100 FQDN
matchPattern
on a node with 20 endpoints.[1]
Signed-off-by: André Martins andre@cilium.io