Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct comment Service6Key and Service4Key #17271

Merged
merged 1 commit into from Sep 2, 2021

Conversation

ChenYahui2019
Copy link

@ChenYahui2019 ChenYahui2019 commented Aug 31, 2021

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Thanks for contributing!

Fixes: #issue-number

@ChenYahui2019 ChenYahui2019 requested a review from a team August 31, 2021 08:16
@maintainer-s-little-helper
Copy link

Commit 5b4b13ba1ae00ba4dd423f7aa9d56999bae4de62 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Aug 31, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Aug 31, 2021
@jibi
Copy link
Member

jibi commented Aug 31, 2021

Thanks for the contribution @ChenYahui2019!
Could you please amend the commit message to: lbmap: correct comment for Service6Key and Service4Key?

@jibi jibi added the release-note/misc This PR makes changes that have no direct user impact. label Aug 31, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 31, 2021
Signed-off-by: chenyahui <chenyahui9@jd.com>
@ChenYahui2019
Copy link
Author

Thanks for the contribution @ChenYahui2019!
Could you please amend the commit message to: lbmap: correct comment for Service6Key and Service4Key?

done

@jibi jibi added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Sep 1, 2021
@jibi
Copy link
Member

jibi commented Sep 1, 2021

No need to run full CI as this is just changing code comments. Marking as ready-to-merge.

@aditighag aditighag merged commit 30f3c2a into cilium:master Sep 2, 2021
@ChenYahui2019 ChenYahui2019 deleted the fix-lb4-key branch September 3, 2021 02:00
@joestringer
Copy link
Member

@jibi How did we merge this without checking off the boxes in the issue description? Those are required to accept a PR.

@jibi
Copy link
Member

jibi commented Sep 30, 2021

@jibi How did we merge this without checking off the boxes in the issue description? Those are required to accept a PR.

Sorry, not sure how I missed the default release-note blurb in the PR description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants