New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
correct comment Service6Key and Service4Key #17271
Conversation
Commit 5b4b13ba1ae00ba4dd423f7aa9d56999bae4de62 does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
5b4b13b
to
fc857fe
Compare
Thanks for the contribution @ChenYahui2019! |
Signed-off-by: chenyahui <chenyahui9@jd.com>
fc857fe
to
ed724fa
Compare
done |
No need to run full CI as this is just changing code comments. Marking as ready-to-merge. |
@jibi How did we merge this without checking off the boxes in the issue description? Those are required to accept a PR. |
Sorry, not sure how I missed the default release-note blurb in the PR description |
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXX
line if the commit addresses a particularGitHub issue.
Fixes: #issue-number