Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hubble-ca-cert ConfigMap cleanup #17294

Merged
merged 2 commits into from
Nov 9, 2021
Merged

hubble-ca-cert ConfigMap cleanup #17294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9020a77
helm: remove hubble-ca-cert from certgen authorization
kaworu Sep 2, 2021
b0d1b54
test: remove unused configmap from CleanupCiliumComponents()
kaworu Sep 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 0 additions & 9 deletions install/kubernetes/cilium/templates/hubble/tls-cronjob/clusterrole.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ rules:
- ""
resources:
- secrets
- configmaps
verbs:
- create
- apiGroups:
Expand All @@ -21,14 +20,6 @@ rules:
- hubble-relay-server-certs
verbs:
- update
- apiGroups:
- ""
resources:
- configmaps
resourceNames:
- hubble-ca-cert
verbs:
- update
- apiGroups:
- ""
resources:
Expand Down
2 changes: 1 addition & 1 deletion test/helpers/kubectl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4383,7 +4383,7 @@ func (kub *Kubectl) CleanupCiliumComponents() {
wg sync.WaitGroup

resourcesToDelete = map[string]string{
"configmap": "cilium-config hubble-ca-cert hubble-relay-config",
Copy link
Member

@gandro gandro Sep 14, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we run a Jenkins CI test for this? I believe we can safely remove it, but since this function here is also used in the upgrade tests (which deploys Cilium v1.10, which afair still creates the hubble-ca-cert ConfigMap), I think it's worth running to ensure we don't break CI via leftover artifacts.

"configmap": "cilium-config hubble-relay-config",
"daemonset": "cilium cilium-node-init",
"deployment": "cilium-operator hubble-relay",
"clusterrolebinding": "cilium cilium-operator hubble-relay",
Expand Down