Revert "Perform reverse NAT at Host Interface" #17319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit dc4b06e. Rationale: - PR cilium#15354 introduced a new test that is frequently failing: `K8sServicesTest Checks service across nodes Tests NodePort BPF Tests with vxlan Test NodePort with netfilterCompatMode=true` - This flake is tracked in issue cilium#17060. - We are reverting the original PR so as to remove the flake from the CI until we have a fix and are confident the new test is not flaky. Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
nbusseneau
added
sig/datapath
|
test-me-please |
pchaigno
approved these changes
Sep 6, 2021
Got one with 0bb3eed#diff-8a383aefc352ba8854dbab293a563fecf7f8916983d013ab36f677293996ca3c because they both added new entries at the end of the |
|
All CI passed, now we're just waiting for approval! /cc @joestringer because we discussed that backport earlier. |
|
Marking ready to merge considering tests are passing and this is just a revert of a complete feature, so probably no need for all reviews. |
pchaigno
added
the
ready-to-merge
This was referenced Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit dc4b06e.
Rationale:
K8sServicesTest Checks service across nodes Tests NodePort BPF Tests with vxlan Test NodePort with netfilterCompatMode=true