Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cilium-cli to v0.9.0 #17330

Merged
merged 1 commit into from
Sep 8, 2021
Merged

Update cilium-cli to v0.9.0 #17330

merged 1 commit into from
Sep 8, 2021

Conversation

tklauser
Copy link
Member

@tklauser tklauser commented Sep 7, 2021

@tklauser tklauser added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels Sep 7, 2021
@tklauser tklauser requested review from a team as code owners September 7, 2021 08:05
@nbusseneau nbusseneau mentioned this pull request Sep 7, 2021
Closed
@nbusseneau
Copy link
Member

GKE https://github.com/cilium/cilium/actions/runs/1208605092 and multicluster https://github.com/cilium/cilium/actions/runs/1208605086 tests both hit cilium/cilium-cli#367.

Since this improves the CI state thanks to the ipcache fix, this is an exception to the zero-flake strategy and we are allowed to merge this once the DO NOT MERGE commit has been removed.

@tklauser tklauser force-pushed the pr/tklauser/update-cilium-cli-v0.9.0 branch from 66915e7 to af8a1d5 Compare September 7, 2021 12:30
@tklauser
Copy link
Member Author

tklauser commented Sep 7, 2021

GKE https://github.com/cilium/cilium/actions/runs/1208605092 and multicluster https://github.com/cilium/cilium/actions/runs/1208605086 tests both hit cilium/cilium-cli#367.

Since this improves the CI state thanks to the ipcache fix, this is an exception to the zero-flake strategy and we are allowed to merge this once the DO NOT MERGE commit has been removed.

Dropped DO NOT MERGE commit and marking as ready to merge.

@tklauser tklauser added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Sep 7, 2021
@joestringer joestringer merged commit 44d5297 into master Sep 8, 2021
@joestringer joestringer deleted the pr/tklauser/update-cilium-cli-v0.9.0 branch September 8, 2021 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer approved these changes

@nbusseneau nbusseneau nbusseneau approved these changes

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tklauser @nbusseneau @joestringer