Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows/L4LB: Reprovision if vagrant up fails #17339

Merged
merged 1 commit into from Sep 8, 2021

Conversation

brb
Copy link
Member

@brb brb commented Sep 8, 2021

Make sure that a subsequent call to "vagrant up" does the provisioning
if a previous call has failed. Otherwise, we will risk running the L4LB
suite on the VM with missing dependencies.

Suggested-by: Paul Chaignon paul@cilium.io
Signed-off-by: Martynas Pumputis m@lambda.lt

Fix #17336

Make sure that a subsequent call to "vagrant up" does the provisioning
if a previous call has failed. Otherwise, we will risk running the L4LB
suite on the VM with missing dependencies.

Suggested-by: Paul Chaignon <paul@cilium.io>
Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb brb added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels Sep 8, 2021
@brb brb requested review from a team as code owners September 8, 2021 10:33
@brb brb requested a review from nbusseneau September 8, 2021 10:34
Copy link
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised we didn't hit this before 🤯 I thought 404 from Fedora were more frequent than that.

@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Sep 8, 2021
@aditighag aditighag merged commit eadc4e9 into master Sep 8, 2021
@aditighag aditighag deleted the pr/brb/fix-l4lb-ci-provisioning branch September 8, 2021 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: Cilium L4LB XDP: clang: command not found
4 participants