Improve output of development VM startup #17343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchaigno
added
release-note/misc
pchaigno
force-pushed
the
improve-vagrant-vm-output
branch
from
99868cd
to
c7ed5b5
Compare
It's probably best to avoid suggesting to run:
export NWORKERS=n
./contrib/vagrant/start.sh
First, users tend to forget they export environment variables, so at
least for new contributors, it's probably best to pass the environment
variables in the start.sh command. Second, the above configuration
doesn't make much sense: starting *several* Runtime (i.e., no Kubernetes)
VMs is almost never useful. The user should refer to the development
guide for the appropriate options instead.
Signed-off-by: Paul Chaignon <paul@cilium.io>
In start.sh, we have some code to detect if there are already running VMs and propose to the user that they stop or delete such VMs. This commit cleans up the output of that code, by removing unnecessary newlines and suggestions. Signed-off-by: Paul Chaignon <paul@cilium.io>
In start.sh, we have some code to detect existing VMs and propose to the user to delete or stop them. After executing those actions, we can directly proceed with start.sh and the provisioning of new development VMs. There's no need for the user to run the command a second time. Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
force-pushed
the
improve-vagrant-vm-output
branch
from
c7ed5b5
to
8833aad
Compare
aditighag
approved these changes
Sep 16, 2021
aditighag
added
the
ready-to-merge
christarazi
changed the title
christarazi
approved these changes
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor clean ups, rewording, and improvements to the development VM startup. See commits for details.