images: Bump Hubble CLI to v0.8.2 #17362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaworu
added
kind/enhancement
rolinh
approved these changes
Sep 10, 2021
tklauser
approved these changes
Sep 10, 2021
There was a problem hiding this comment.
LGTM once the lint job failure is addressed: https://github.com/cilium/cilium/runs/3566389926?check_suite_focus=true
kaworu
force-pushed
the
pr/kaworu/hubble-cli-v0.8.2
branch
from
4fc2130
to
5cd67b7
Compare
Ok now I understand the printf trick at https://github.com/cilium/cilium/blob/5cd67b7be6e9ebb177c6fe8854e4c559f65306b4/images/scripts/make-image-tag.sh#L57 |
kaworu
force-pushed
the
pr/kaworu/hubble-cli-v0.8.2
branch
from
5cd67b7
to
7f88508
Compare
joestringer
approved these changes
Sep 13, 2021
gandro
approved these changes
Sep 14, 2021
kaworu
added
the
ready-to-merge
kaworu
force-pushed
the
pr/kaworu/hubble-cli-v0.8.2
branch
from
7f88508
to
8acc8c4
Compare
…h parameter Before this patch, update-hubble-version.sh would not accept the form X.Y.Z. The error message in that case was a 404 from curl failing to download the release which didn't help understanding the underlying issue with the version argument. Signed-off-by: Alexandre Perrin <alex@kaworu.ch>
Signed-off-by: Alexandre Perrin <alex@kaworu.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.