Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support serviceAnnotations to helm-metrics service #17366

Conversation

carloscastrojumo
Copy link
Contributor

This commit introduces a new Helm parameter, hubble.metrics.serviceAnnotations to enable annotations in helm-metrics service.

Example

Enable Kubernetes Integrations Autodiscovery used by Datadog:

hubble:
  metrics:
    serviceAnnotations:
      ad.datadoghq.com/endpoints.check_names: '["openmetrics"]'
      ad.datadoghq.com/endpoints.init_configs: '[{}]'
      ad.datadoghq.com/endpoints.instances: '[{"prometheus_url": "http://%%host%%:9091/metrics",
"namespace":"cilium-system","metrics": ["hubble*"]}]'

Signed-off-by: Carlos Castro <carlos.castro@jumo.world>
@carloscastrojumo carloscastrojumo requested a review from a team as a code owner September 10, 2021 17:38
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 10, 2021
Signed-off-by: Carlos Castro <carlos.castro@jumo.world>
@kaworu kaworu added area/helm Impacts helm charts and user deployment experience release-note/misc This PR makes changes that have no direct user impact. labels Sep 14, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Sep 14, 2021
@kaworu
Copy link
Member

kaworu commented Sep 16, 2021

No need for a full CI run, marking as ready-to-merge as reviews are done.

Thanks @carloscastrojumo for the patch!

@kaworu kaworu added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Sep 16, 2021
@christarazi christarazi merged commit e83f5c6 into cilium:master Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm Impacts helm charts and user deployment experience ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants