New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ipam/allocator/podcidr: fix old pod cidr logging error #17372
Conversation
test-me-please Job 'Cilium-PR-K8s-GKE' failed and has not been observed before, so may be related to your PR: Click to show.Test Name
Failure Output
If it is a flake, comment |
@twpayne My PR just replaces log.Debug with log.Info. it's weird that some unrelated test cases have failed. Please help ! Thanks. |
We have a few flaky tests at the moment, the failures have nothing to do with your PR. Note also that the test-me-please comment is to trigger CI to run, not a message to you :) |
👍 . Thanks for explanations. |
@twpayne Hi, does there any update about this PR ? We have found some issues about cilium IPAM which could lead to pod cidr conflict. This is the first try to fix it. |
Would you mind rebasing this PR on the latest |
When releasing a pod cidr of a node, this pod cidr field is appended to the log cache. But log cache could not be flushed because log is not in debug mode. So old pod cidr is always in the log cache and shows up in the log output even after a new pod cidr is allocated. Fix this error by flushing the log cache. Signed-off-by: kaixi.fan <fankaixi.li@bytedance.com> Signed-off-by: xiexiaohui.xxh <xiexiaohui.xxh@bytedance.com>
OK, approved as it's a trivial change and marked ready-to-merge. I'll still keep an eye on the tests as it's a good barometer PR for our CI :) |
Thanks. By the way, we are working to build a local cilium CI/CD system. I fount that it's hard to do this. I have to build cilium-runtime again and again, and have to push them to a private repo to be used by following building steps. |
1 similar comment
Thanks. By the way, we are working to build a local cilium CI/CD system. I fount that it's hard to do this. I have to build cilium-runtime again and again, and have to push them to a private repo to be used by following building steps. |
When releasing a pod cidr of a node, this pod cidr field is appended to
the log cache. But log cache could not be flushed because log is not in
debug mode. So old pod cidr is always in the log cache and shows up in
the log output even after a new pod cidr is allocated.
Fix this error by flushing the log cache.