Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-doctor: use default GOPATH when missing from env #17385

Merged
merged 1 commit into from Sep 14, 2021
Merged

dev-doctor: use default GOPATH when missing from env #17385

merged 1 commit into from Sep 14, 2021

Conversation

kaworu
Copy link
Member

@kaworu kaworu commented Sep 13, 2021

No description provided.

@kaworu
dev-doctor: use default GOPATH when missing from env
7b43bde 
Signed-off-by: Alexandre Perrin <alex@kaworu.ch>
@kaworu kaworu added priority/low This is considered nice to have. kind/cleanup This includes no functional changes. area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. release-note/misc This PR makes changes that have no direct user impact. labels Sep 13, 2021
@kaworu kaworu requested a review from twpayne September 13, 2021 20:01
@kaworu kaworu self-assigned this Sep 13, 2021
@kaworu kaworu requested a review from a team as a code owner September 13, 2021 20:01
twpayne
twpayne approved these changes Sep 13, 2021
View reviewed changes
Copy link
Contributor

@twpayne twpayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement :)

@aditighag aditighag added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Sep 13, 2021
@kaworu kaworu merged commit 33afb32 into cilium:master Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twpayne twpayne twpayne approved these changes

@aditighag aditighag aditighag approved these changes

Assignees

@kaworu kaworu

Labels
area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. kind/cleanup This includes no functional changes. priority/low This is considered nice to have. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kaworu @twpayne @aditighag