-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vagrant: bump all Vagrant box versions #17394
Conversation
test-me-please |
test-1.16-netnext |
Looks like this is timing out on waiting for the kubelet to become ready: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.16-net-next/1445/ I think this is also what happened on the previous run and on the previous PR #17352. I've tried to reproduce this locally but so far wasn't able to (i.e. the VMs always come up as expected with the new VM image). |
test-me-please
I was using the dev VM instructions instead of the CI VM instructions (thanks @nbusseneau for pointing this out). Using
The following looks like the culprit for failing to start
Not sure where that |
Starting But it smells a bit like that value could come from a sysctl or sysfs file. And indeed, if I check for uses of which gets called from here: Comparing the content of that file for the
with my development machine running kernel 5.11:
Notice the trailing null byte |
It's indeed a kernel regression which incidentally breaks I've sent a potential fix upstream: https://lore.kernel.org/lkml/20210916222705.13554-1-tklauser@distanz.ch/T/#u |
Patch was applied to the driver-core tree and should hopefully hit Linus' tree for 5.15-rc3. Marking this PR as draft until that is the case and bpf-next picked up the fix as well at which point we'd need to build new net-next VM images to pick up into this PR. |
Add a patch [1] to the bpf-next kernel build which fixes a regression which causes kubelet to error out on startup. See [2] and following comments for details. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c86a2d9058c5a4a05d20ef89e699b7a6b2c89da6 [2] cilium/cilium#17394 (comment) Suggested-by: Daniel Borkmann <daniel@iogearbox.net> Signed-off-by: Tobias Klauser <tobias@cilium.io>
Quick status update: The patch has made it upstream into Linus' tree but hasn't made it into the bpf-next tree yet. In order to unblock this PR and PRs depending on a Vagrant VM bump, I've opened cilium/packer-ci-build#284 which applies said patch manually before building the kernel for the bpf-next kernel image. Once that is approved and merged and a new VM image was built, we can finally move forward with this PR. |
Add a patch [1] to the bpf-next kernel build which fixes a regression which causes kubelet to error out on startup. See [2] and following comments for details. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c86a2d9058c5a4a05d20ef89e699b7a6b2c89da6 [2] cilium/cilium#17394 (comment) Suggested-by: Daniel Borkmann <daniel@iogearbox.net> Signed-off-by: Tobias Klauser <tobias@cilium.io>
fb7a90e
to
0e568db
Compare
/test Updated to the latest VM image versions (namely to include the kernel patch mentioned above) and included a revert of commit 1c42ae9 as suggested by Paul. Job 'Cilium-PR-K8s-GKE' failed and has not been observed before, so may be related to your PR: Click to show.Test Name
Failure Output
If it is a flake, comment |
/test |
/test |
7c71eb5
to
c4d8872
Compare
/test Job 'Cilium-PR-K8s-GKE' failed and has not been observed before, so may be related to your PR: Click to show.Test Name
Failure Output
If it is a flake, comment |
c4d8872
to
77e265a
Compare
/test |
test-runtime Failed to import image: https://jenkins.cilium.io/job/Cilium-PR-Runtime-net-next/303/ Job 'Cilium-PR-K8s-1.20-kernel-4.19' failed and has not been observed before, so may be related to your PR: Click to show.Test Name
Failure Output
If it is a flake, comment |
ci-eks Failed to create cluster: https://github.com/cilium/cilium/runs/3824163280 |
Pick up Go 1.17 and ipset. Signed-off-by: Tobias Klauser <tobias@cilium.io>
This reverts commit 1c42ae9. Reason for revert: ipset is now provided in the vagrant images Suggested-by: Paul Chaignon <paul@cilium.io> Signed-off-by: Tobias Klauser <tobias@cilium.io>
77e265a
to
51f8b7e
Compare
/test |
CI finally passed 🎉 (except for AKS which is disabled) and reviews are in. Marked as ready to merge. |
Now that the CI infrastructure runs Go 1.17 everywhere (#17394), we can use Go 1.17 features like math.MaxInt. Signed-off-by: Tom Payne <tom@isovalent.com>
Now that the CI infrastructure runs Go 1.17 everywhere (#17394), we can use Go 1.17 features like math.MaxInt. Signed-off-by: Tom Payne <tom@isovalent.com>
Mostly to pick up Go 1.17
Supersedes #17352 which used the wrong branch name, see #17352 (comment) Otherwise no changes to the PR contents.