docs: Update packer-ci-build docs #17395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: helm-values.rst is autogenerated, presumably this is updated because a previous run of make tests-docs was missed. Signed-off-by: Tom Payne <tom@isovalent.com>
twpayne
added
area/documentation
qmonnet
approved these changes
Sep 14, 2021
There was a problem hiding this comment.
The documentation change looks good to me.
Regarding the update of the Helm values, looks good too, but I thought the CI would catch an omission. Looking into it, I wonder if we check for those updates at all. We do make sure that the CI builds the documentation when the Helm values are changed, and this should catch any error at build time (such as a new technical word not added to the spelling file), but if the doc builds with no error, I'm not sure we're actually checking for differences with the existing reference, as we do for commands with Documentation/check-cmdref.sh for example. Anyway. I need to double-check and fix this at some point, but this is independent from the current PR.
nbusseneau
approved these changes
Sep 14, 2021
twpayne
added
the
ready-to-merge
kaworu
approved these changes
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: helm-values.rst is autogenerated, presumably this is updated
because a previous run of make tests-docs was missed.
Signed-off-by: Tom Payne tom@isovalent.com