Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Use cilium sysdump instead of python sysdump #17402

Merged
merged 1 commit into from Sep 15, 2021
Merged

docs: Use cilium sysdump instead of python sysdump #17402

merged 1 commit into from Sep 15, 2021

Conversation

michi-covalent
Copy link
Contributor

Python sysdump has been deprecated.

Ref: https://github.com/cilium/cilium-sysdump

Signed-off-by: Michi Mutsuzaki michi@isovalent.com

@michi-covalent
docs: Use cilium sysdump instead of python sysdump
cad166e 
Python sysdump has been deprecated.

Ref: https://github.com/cilium/cilium-sysdump

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
@michi-covalent michi-covalent added the release-note/misc This PR makes changes that have no direct user impact. label Sep 14, 2021
@michi-covalent michi-covalent requested a review from a team as a code owner September 14, 2021 23:55
@michi-covalent
Copy link
Contributor Author

deploy preview: https://614136554d4e0e0007313507--cilium-doc.netlify.app/operations/troubleshooting.html#reporting-a-problem

qmonnet
qmonnet approved these changes Sep 15, 2021
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@qmonnet qmonnet added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Sep 15, 2021
tklauser
tklauser approved these changes Sep 15, 2021
View reviewed changes
Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@aanm aanm merged commit 339baa8 into cilium:master Sep 15, 2021
@michi-covalent michi-covalent deleted the pr/michi/sysdump branch September 15, 2021 15:05
@pchaigno
Copy link
Member

Any reason this wasn't marked for backports? The link in the #general Slack channel still points to the old method as a result (it points to the stable docs).

@michi-covalent
Copy link
Contributor Author

no particular reason, let's backport it

@nebril nebril mentioned this pull request Oct 28, 2021
Merged
@joestringer joestringer mentioned this pull request Dec 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tklauser tklauser tklauser approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@michi-covalent @pchaigno @tklauser @qmonnet @nebril @aanm