New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Increase the CI image wait timeout to 30 minutes #17409
Conversation
There are many CI image build runs that take more than 10 minutes to complete because of the GitHub Actions concurrency limit. It would be ideal if we can serialize workflow runs so that tests start after the CI image build finishes, but in the meantime increase the wait time to 30 minutes as a short term workaround to prevent unnecessary failures. Ref: https://github.com/cilium/cilium/actions/workflows/build-images-ci.yaml Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 This will cause some jobs to wait around for a while if the images for whatever reason fail to be pushed, causing a larger pile up from the infra perspective. Are we convinced this is the best approach?
definitely not the best approach, more of a short term mitigation. i'm hoping we can use workflow_dispatch or something to trigger test runs only after the CI image job finishes, but @nbusseneau mentioned there were some limitations in github actions the last time he tried to do that 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's ship it as a short term solution then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like it but let's ship it as a short term fix. Hopefully what I'm working on right now can address that in the longer term...
There are many CI image build runs that take more than 10 minutes to
complete because of the GitHub Actions concurrency limit. It would be
ideal if we can serialize workflow runs so that tests start after the
CI image build finishes, but in the meantime increase the wait time to
30 minutes as a short term workaround to prevent unnecessary failures.
Ref: https://github.com/cilium/cilium/actions/workflows/build-images-ci.yaml
Signed-off-by: Michi Mutsuzaki michi@isovalent.com