Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workflows: issue_comment triggers refactoring #17419

Merged
merged 5 commits into from
Sep 27, 2021
Merged

workflows: issue_comment triggers refactoring #17419

merged 5 commits into from
Sep 27, 2021

Commits on Sep 24, 2021

  1. workflows: reformat issue_comment-based checks 

    Ensure all checks use a consistent format.

Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
    @nbusseneau
    nbusseneau committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    ff736a3 View commit details
    Browse the repository at this point in the history

  2. workflows: add /test and /-prefixed triggers 

    For now keep the previous and new triggers as a transition phase.

Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
    @nbusseneau
    nbusseneau committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    b528b38 View commit details
    Browse the repository at this point in the history

  3. workflows: harden startsWith checks 

    This will avoid triggering both regular and 1.10 CI when commenting
`/test-backport-1.10` on a backport PR, while still allowing additional
comments or newlines after the initial test trigger phrase.

Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
    @nbusseneau
    nbusseneau committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    e699438 View commit details
    Browse the repository at this point in the history

  4. update MLH config with new /test trigger 

    Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
    @nbusseneau
    nbusseneau committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    417c779 View commit details
    Browse the repository at this point in the history

  5. documentation: update trigger phrases 

    - `test-me-please` replaced with `/test`.
- `build-me-please` replace with `/build`.
- Other triggers as-is but prefixed with `/`.
- Unified race detection trigger phrases with the rest of the document:
  singular race detection jobs will expose their unique trigger phrases
  directly from the PR checks.

Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
    @nbusseneau
    nbusseneau committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    3d0bba0 View commit details
    Browse the repository at this point in the history