contrib/vagrant/start.sh: add a NO_BUILD export #17425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkourt
added
the
release-note/misc
pchaigno
approved these changes
Sep 17, 2021
pchaigno
added
the
sig/contributing
Add an export for NO_BUILD, to make it clear(er) that this option is available. Ideally, we would want argument options instead of environment variables for this script, but that's a bigger change. Signed-off-by: Kornilios Kourtis <kornilios@isovalent.com>
kkourt
force-pushed
the
pr/kkourt/vagrant-start-nobuild
branch
from
5296e99
to
5fde98b
Compare
kkourt
changed the title
fixed, thanks! |
|
test-me-please |
pchaigno
added
the
ready-to-merge
|
We don't have any tests covering this script, so marking ready to merge. |
qmonnet
approved these changes
Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an export for NO_BUILD, to make it clear(er) that this option is
available.
Ideally, we would want argument options instead of environment variables for this
script, but that's a bigger change.
Signed-off-by: Kornilios Kourtis kornilios@isovalent.com