workflows: Use new cilium sysdump
#17428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchaigno
added
area/CI
nbusseneau
reviewed
Sep 17, 2021
pchaigno
commented
Sep 17, 2021
| tar zxf hubble-linux-amd64.tar.gz | ||
| chmod +x ./hubble | ||
| touch hubble-flows.json | ||
| ./hubble observe --all --output json > hubble-flows.json || true |
There was a problem hiding this comment.
For reviewers: We don't need this anymore as it's already included in the sysdump.
pchaigno
force-pushed
the
pr/pchaigno/use-cilium-sysdump-2.0
branch
from
89aaaea
to
9727a5d
Compare
christarazi
approved these changes
Sep 17, 2021
We've already been using the new cilium sysdump command in cilium-cli for a while, we can start using it in cilium/cilium as well. One advantage of using this new command is that we'll now have the Hubble flows in the sysdump. Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
force-pushed
the
pr/pchaigno/use-cilium-sysdump-2.0
branch
from
9727a5d
to
ddf6dad
Compare
pchaigno
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've already been using the new
cilium sysdumpcommand in cilium-cli for a while, we can start using it in cilium/cilium as well. One advantage of using this new command is that we'll now have the Hubble flows in the sysdump.Tested with 89aaaea where some tests failed and sysdumps were correctly collected.