Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FQDN memory leak #17432

Merged
merged 2 commits into from
Sep 22, 2021
Merged

Fix FQDN memory leak #17432

merged 2 commits into from
Sep 22, 2021

Commits on Sep 17, 2021

  1. pkg/fqdn: clean unused code 

    The public function ForceExpiredByNames is not executed from anywhere so
this function can be safely removed.

Signed-off-by: André Martins <andre@cilium.io>
    @aanm
    aanm committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    0a1ee91 View commit details
    Browse the repository at this point in the history

  2. pkg/fqdn: fix memory leak 

    In the FQDN architecture there's a DNS Cache per endpoint, used to track
which domain names each endpoint makes DNS requests, and a global DNS
Cache where its main functionality is to help tracking which
api.FQDNSelector present in the policy applies to locally running
endpoints. The latter, as opposed to the former, didn't have any
cleanup mechanism for the map that tracked which entries should be
garbage collected, making the global DNS Cache to grow.
This commit prevents those entries from being tracked for Garbage
Collection in the global DNS Cache.

Signed-off-by: André Martins <andre@cilium.io>
    @aanm
    aanm committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    ff06ce6 View commit details
    Browse the repository at this point in the history