Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add note about selecting proper interface name for masquerading #17443

Merged
merged 1 commit into from Sep 21, 2021
Merged

add note about selecting proper interface name for masquerading #17443

merged 1 commit into from Sep 21, 2021

Conversation

wronghost
Copy link

Added small note to documentation about egressMasqueradeInterfaces option. For linux distributions like Fedora CoreOS, network interfaces have different naming like ens5 not eth0.

Signed-off-by: Kamil Lach kamil.lach.rs@gmail.com

@wronghost
add note about selecting proper interface name for masquerading
12e6465 
Signed-off-by: Kamil Lach <kamil.lach.rs@gmail.com>
@wronghost wronghost requested a review from a team as a code owner September 21, 2021 00:16
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 21, 2021
@joestringer joestringer added the release-note/misc This PR makes changes that have no direct user impact. label Sep 21, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 21, 2021
@joestringer joestringer added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Sep 21, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 21, 2021
qmonnet
qmonnet approved these changes Sep 21, 2021
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the changes!

@qmonnet qmonnet added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Sep 21, 2021
@christarazi christarazi merged commit 5d8373a into cilium:master Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wronghost @joestringer @qmonnet @christarazi