Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation/gettingstarted: fix helm arguments #17496

Merged
merged 1 commit into from
Sep 29, 2021
Merged

Documentation/gettingstarted: fix helm arguments #17496

merged 1 commit into from
Sep 29, 2021

Conversation

AlexZzz
Copy link
Contributor

@AlexZzz AlexZzz commented Sep 29, 2021

Hi!
This is a small documentation fix: namespace argument should be passed to be consistent with ConfigMap.

@AlexZzz AlexZzz requested a review from a team as a code owner September 29, 2021 12:30
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 29, 2021
qmonnet
qmonnet requested changes Sep 29, 2021
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks a lot for the PR!

One comment below.
Could you also please add a short description to your commit log?

Documentation/gettingstarted/bgp.rst Outdated Show resolved Hide resolved
@qmonnet qmonnet added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels Sep 29, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 29, 2021
@AlexZzz
Documentation/gettingstarted: fix helm arguments
8142427 
Pass --namespace argument in consistence with ConfigMap.

Signed-off-by: Aleksei Zakharov <zakharov.a.g@yandex.ru>
qmonnet
qmonnet approved these changes Sep 29, 2021
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change!

@qmonnet qmonnet added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Sep 29, 2021
@qmonnet qmonnet mentioned this pull request Sep 29, 2021
Merged
@glibsm glibsm merged commit 788f41a into cilium:master Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AlexZzz @qmonnet @glibsm