Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Quarantine K8sServicesTest Check services across nodes #17514

Merged
merged 1 commit into from Oct 11, 2021
Merged

test: Quarantine K8sServicesTest Check services across nodes #17514

merged 1 commit into from Oct 11, 2021

Conversation

@twpayne twpayne added area/CI Continuous Integration testing issue or flake release-note/misc This PR makes changes that have no direct user impact. labels Oct 1, 2021
@twpayne
Copy link
Contributor Author

twpayne commented Oct 1, 2021

/test

@twpayne
Copy link
Contributor Author

twpayne commented Oct 4, 2021

/ci-awscni

@twpayne
Copy link
Contributor Author

twpayne commented Oct 4, 2021

/test

test/k8sT/Services.go Outdated Show resolved Hide resolved
This test has been unreliable for some time:
- #12511
- #16399
- #16971
- #17176

Signed-off-by: Tom Payne <tom@isovalent.com>
@pchaigno
Copy link
Member

/test

@twpayne
Copy link
Contributor Author

twpayne commented Oct 11, 2021

First Travis failure was due to hitting the Docker image pull rate limit (#17002).

Second Travis failure looks like #11560.

@pchaigno
Copy link
Member

Given the test failures are unrelated and this PR is quarantining tests, could we proceed and merge it despite the failures? Otherwise we risk hitting a chicken and egg problem 😸

@twpayne
Copy link
Contributor Author

twpayne commented Oct 11, 2021

Given the test failures are unrelated and this PR is quarantining tests, could we proceed and merge it despite the failures? Otherwise we risk hitting a chicken and egg problem 😸

Agreed :) Let's let the rest of the tests complete though to see what other flakes we get.

@pchaigno
Copy link
Member

Given the test failures are unrelated and this PR is quarantining tests, could we proceed and merge it despite the failures? Otherwise we risk hitting a chicken and egg problem smile_cat

Agreed :) Let's let the rest of the tests complete though to see what other flakes we get.

They all finished already. The CI 3.0 tests won't start because you're PR only touches test/ so they are not affected.

@twpayne twpayne marked this pull request as ready for review October 11, 2021 12:17
@twpayne twpayne requested a review from a team as a code owner October 11, 2021 12:17
@twpayne twpayne requested review from a team, tklauser and jibi October 11, 2021 12:17
@twpayne twpayne added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 11, 2021
@errordeveloper errordeveloper merged commit cb1d3b3 into cilium:master Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants