doc: hubble configuration cleanup #17522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaworu
added
kind/enhancement
joestringer
approved these changes
Oct 4, 2021
kaworu
force-pushed
the
pr/kaworu/doc/hubble-configuration-cleanup
branch
from
234f544
to
6a0ba81
Compare
joestringer
requested changes
Oct 5, 2021
kaworu
force-pushed
the
pr/kaworu/doc/hubble-configuration-cleanup
branch
from
6a0ba81
to
1015fd7
Compare
|
Thanks for the comments @joestringer. Hopefully I've addressed all of them, please take another look! |
joestringer
approved these changes
Oct 7, 2021
rolinh
approved these changes
Oct 12, 2021
kaworu
force-pushed
the
pr/kaworu/doc/hubble-configuration-cleanup
branch
from
1015fd7
to
3531d0a
Compare
Rewording, add links to the cert-manager issuers, avoid shell command with three-dots. Signed-off-by: Alexandre Perrin <alex@kaworu.ch>
This patch remove two items from the cert-manager advantage list, so that the two remaining items are highlighted. cert-manager not needing a Kubernetes CronJob is arguably counter-balanced by the fact that ones needs all the cert-manager Pods running. Remove the "Renew certificates automatically" item, as the previously mentioned certgen method in the documentation is able to automatically renew certificates as well. Signed-off-by: Alexandre Perrin <alex@kaworu.ch>
seanmwinn
approved these changes
Oct 15, 2021
|
No need for a full CI run here as this PR only contains documentation changes, marking as |
kaworu
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the hubble TLS configuration by rewording, and adding links to external resources.