helm: Expose l2 neigh discovery related agent flags #17526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brb
added
area/helm
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
brb
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
brb
force-pushed
the
pr/brb/helm-enable-l2-neigh-discovery
branch
from
200aeae
to
b97b9cc
Compare
joestringer
approved these changes
Oct 4, 2021
kaworu
requested changes
Oct 5, 2021
brb
force-pushed
the
pr/brb/helm-enable-l2-neigh-discovery
branch
from
b97b9cc
to
b589cda
Compare
This commit exposes the following flags: - "--enable-l2-neigh-discovery" via "l2NeighDiscovery.enabled". - "--arping-refresh-period" via "l2NeighDiscovery.refreshPeriod". Signed-off-by: Martynas Pumputis <m@lambda.lt>
nathanjsweet
approved these changes
Oct 5, 2021
kaworu
approved these changes
Oct 6, 2021
|
test-1.20-4.19 |
brb
added
ready-to-merge
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.10
in 1.10.5
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.10
in 1.10.5
nbusseneau
added a commit
to nbusseneau/cilium
that referenced
this pull request
Oct 11, 2021
It seems we forgot to update `helm-values.rst` in cilium#17526, yielding issues when building documentation locally with `make render-docs`: ``` Please fix the following spelling mistakes: * Documentation/helm-reference.rst:876: (NeighDiscovery) * Documentation/helm-reference.rst:876: (arping) * Documentation/helm-reference.rst:877: (arping) * Documentation/helm-reference.rst:880: (NeighDiscovery) * Documentation/helm-reference.rst:881: (neighbour) * Documentation/helm-values.rst:876: (NeighDiscovery) * Documentation/helm-values.rst:876: (arping) * Documentation/helm-values.rst:877: (arping) * Documentation/helm-values.rst:880: (NeighDiscovery) * Documentation/helm-values.rst:881: (neighbour) If the words are not misspelled, run: Documentation/update-spelling_wordlist.sh NeighDiscovery arping neighbour ``` Since we already have more occurrences of `neighbor` (US spelling) in the repo, we replace `neighbour` with `neighbour` for consistency and then fix `helm-values.rst` + spelling wordlist. Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
maintainer-s-little-helper
bot
moved this from Backport pending to v1.10
to Backport done to v1.10
in 1.10.5
errordeveloper
pushed a commit
that referenced
this pull request
Oct 12, 2021
It seems we forgot to update `helm-values.rst` in #17526, yielding issues when building documentation locally with `make render-docs`: ``` Please fix the following spelling mistakes: * Documentation/helm-reference.rst:876: (NeighDiscovery) * Documentation/helm-reference.rst:876: (arping) * Documentation/helm-reference.rst:877: (arping) * Documentation/helm-reference.rst:880: (NeighDiscovery) * Documentation/helm-reference.rst:881: (neighbour) * Documentation/helm-values.rst:876: (NeighDiscovery) * Documentation/helm-values.rst:876: (arping) * Documentation/helm-values.rst:877: (arping) * Documentation/helm-values.rst:880: (NeighDiscovery) * Documentation/helm-values.rst:881: (neighbour) If the words are not misspelled, run: Documentation/update-spelling_wordlist.sh NeighDiscovery arping neighbour ``` Since we already have more occurrences of `neighbor` (US spelling) in the repo, we replace `neighbour` with `neighbour` for consistency and then fix `helm-values.rst` + spelling wordlist. Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit exposes the following flags:
--enable-l2-neigh-discoveryvial2NeighDiscovery.enabled.--arping-refresh-periodvial2NeighDiscovery.refreshPeriod.