Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix docs following #17238 #17530

Merged
merged 1 commit into from Oct 5, 2021
Merged

Conversation

nbusseneau
Copy link
Member

@nbusseneau nbusseneau commented Oct 4, 2021

It seems we forgot to update helm-values.rst in #17238, yielding issues when building documentation locally with make render-docs.

Please fix the following spelling mistakes:
* Documentation/helm-reference.rst:172: (certManagerIssuerRef) 
* Documentation/helm-reference.rst:173: (certmanager) 
* Documentation/helm-reference.rst:173: (certmanager) 
* Documentation/helm-reference.rst:208: (extraDnsNames) 
* Documentation/helm-reference.rst:212: (extraIpAddresses) 
* Documentation/helm-reference.rst:580: (serviceAnnotations) 
* Documentation/helm-reference.rst:660: (extraDnsNames) 
* Documentation/helm-reference.rst:664: (extraIpAddresses) 
* Documentation/helm-reference.rst:688: (certManagerIssuerRef) 
* Documentation/helm-reference.rst:689: (certmanager) 
* Documentation/helm-reference.rst:689: (certmanager) 
* Documentation/helm-reference.rst:701: (certmanager) 
* Documentation/helm-reference.rst:724: (extraDnsNames) 
* Documentation/helm-reference.rst:728: (extraIpAddresses) 
* Documentation/helm-values.rst:172: (certManagerIssuerRef) 
* Documentation/helm-values.rst:173: (certmanager) 
* Documentation/helm-values.rst:173: (certmanager) 
* Documentation/helm-values.rst:208: (extraDnsNames) 
* Documentation/helm-values.rst:212: (extraIpAddresses) 
* Documentation/helm-values.rst:580: (serviceAnnotations) 
* Documentation/helm-values.rst:660: (extraDnsNames) 
* Documentation/helm-values.rst:664: (extraIpAddresses) 
* Documentation/helm-values.rst:688: (certManagerIssuerRef) 
* Documentation/helm-values.rst:689: (certmanager) 
* Documentation/helm-values.rst:689: (certmanager) 
* Documentation/helm-values.rst:701: (certmanager) 
* Documentation/helm-values.rst:724: (extraDnsNames) 
* Documentation/helm-values.rst:728: (extraIpAddresses)

It seems we forgot to update `helm-values.rst` in cilium#17238, yielding
issues when building documentation locally with `make render-docs`.

Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
@nbusseneau nbusseneau added the area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. label Oct 4, 2021
@nbusseneau nbusseneau requested a review from a team as a code owner October 4, 2021 17:15
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 4, 2021
@nbusseneau nbusseneau requested review from joestringer and removed request for qmonnet October 4, 2021 17:15
@nbusseneau nbusseneau added the release-note/misc This PR makes changes that have no direct user impact. label Oct 4, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 4, 2021
@nbusseneau nbusseneau added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 4, 2021
@nbusseneau
Copy link
Member Author

This only changes documentation, running CI not needed, other checks are green. Marking as ready to merge.

@glibsm glibsm merged commit 8512f16 into cilium:master Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants