Add documentation for vlan bpf bypass. #17539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
qmonnet
requested changes
Oct 5, 2021
There was a problem hiding this comment.
Content looks good, although I suggested a bunch of edits for the grammar and phrasing. Please have a look: a few are typos and need be addressed, but other than this you don't necessarily have to adopt all of my suggestions.
Thanks a lot for the contribution!
qmonnet
added
area/documentation
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
qmonnet
approved these changes
Oct 6, 2021
Follow-up for PR: cilium#16772 Signed-off-by: Viktor Kuzmin <kvaster@gmail.com>
pchaigno
approved these changes
Oct 11, 2021
|
|
||
| The list of allowed VLAN tags cannot be too big in order to keep eBPF program of predictable size. Currently this list | ||
| should contain no more than 5 entries. If you need more, then there is only one way for now: you need to allow | ||
| all tags with cilium-agent flag ``--vlan-bpf-bypass=0``. |
There was a problem hiding this comment.
I understand this limit was added to avoid complexity issues. Did anyone actually validate that it works with 5 VLAN tags? What other options were enabled during that test?
If we want to cover this in CI, I think we should extend the MAX_HOST_OPTIONS macro in bpf/Makefile.
/cc @joestringer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation for vlan bpf bypass.
Follow-up for PR: #16772
Signed-off-by: Viktor Kuzmin kvaster@gmail.com