datapath: allow specifying cilium_host routes metric #17544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
aanm
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
|
/test |
This comment has been minimized.
This comment has been minimized.
Frankkkkk
force-pushed
the
fvd/cilium-route-metric
branch
from
51b1b97
to
b55596b
Compare
|
You'll need to rebase with latest master for build-commits to pass (I'd recommend to rebase whenever you update the PR branch). The above error is also still present. See Travis CI build for example. |
Frankkkkk
force-pushed
the
fvd/cilium-route-metric
branch
from
b55596b
to
7b49a69
Compare
Frankkkkk
force-pushed
the
fvd/cilium-route-metric
branch
2 times, most recently
from
5db3bda
to
0748ea7
Compare
The networks used by cilium (pod range, etc.) must be routed to the nodes. One possibility of announcing the ranges is to add them to the `lo` interface. Then, a specific route-map on the local router will announce all the networks belonging to an interface. However, when adding an IP or a range to an interface, the kernel automatically adds a route to it like so: ``` 2001:my:range::/112 dev lo proto kernel metric 256 pref medium ``` this metric corresponds to `IP6_RT_PRIO_ADDRCONF = 256`. The problem arises the moment cilium adds these routes to the cilium host device. If a metric is not specified (by default 0), then the kernel will use `IP6_RT_PRIO_USER = 1024`, which won't take precedence over the above route. We thus introduce the `--route-metric` param which allows overriding this metric. If the param is not used, the default metrics won't change. Fixes: cilium#16539 Signed-off-by: Frank Villaro-Dixon <frank.villaro@infomaniak.com>
Frankkkkk
force-pushed
the
fvd/cilium-route-metric
branch
from
0748ea7
to
6df5d7c
Compare
This comment has been minimized.
This comment has been minimized.
|
Hi @pchaigno thanks for the test and sorry for the huge delay on my part :(. I don't see how the 2 failed tests could be related to this MR ? Thanks ! |
|
Seems like the GKE failure was caused by a connectivity blip with kube-apiserver. Restarting to be sure. /test-gke The k8s-1.21-kernel-4.19 failure seems to be known flake #12690. |
pchaigno
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The networks used by cilium (pod range, etc.) must be routed to the
nodes. One possibility of announcing the ranges is to add them to the
lointerface. Then, a specific route-map on the local router will announceall the networks belonging to an interface.
However, when adding an IP or a range to an interface, the kernel
automatically adds a route to it like so:
this metric corresponds to
IP6_RT_PRIO_ADDRCONF = 256.The problem arises the moment cilium adds these routes to the cilium host
device. If a metric is not specified (by default 0), then the kernel will use
IP6_RT_PRIO_USER = 1024, which won't take precedence over the aboveroute.
We thus introduce the
--route-metricparam which allows overridingthis metric. If the param is not used, the default metrics won't change.
Fixes: #16539
Signed-off-by: Frank Villaro-Dixon frank.villaro@infomaniak.com