Revert "operator: only GC identity keys of its own cluster" #17549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e646d3e. Original PR: cilium#16825 Rationale: breaks multicluster functionality at install time with ``` level=fatal msg="Unable to initialize Identity Allocator with backend crd" error="maximum ID must be greater than minimum ID" subsys=identity-cache ``` when `--cluster-id` is set to a non-default value (e.g. `1`, as in our CI). Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
nbusseneau
added
area/clustermesh
|
/cc original author @ArthurChiao for information: @jrajahalme has provided some ideas of how to revisit the original fix in a comment to the original PR: #16825 (comment) |
tklauser
approved these changes
Oct 6, 2021
|
/ci-multicluster Link to successful workflow run: https://github.com/cilium/cilium/actions/runs/1312498764 |
|
Multicluster test passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit e646d3e.
Original PR: #16825
Rationale: breaks multicluster functionality at install time with
when
--cluster-idis set to a non-default value (e.g.1, as in our CI).